Skip to content

Conversation

@GarrettBeatty
Copy link
Contributor

@GarrettBeatty GarrettBeatty commented Mar 21, 2025

Issue #, if available: DOTNET-7436

Description of changes:

  1. Add README files to sample apps
  2. Update dependencies of sample apps and update for them use net8

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@GarrettBeatty GarrettBeatty added the Release Not Needed Add this label if a PR does not need to be released. label Mar 21, 2025
@GarrettBeatty GarrettBeatty marked this pull request as ready for review March 24, 2025 14:16
Using AWS CLI:
```
$messageBody = "{""""type"""":""""chatMessage"""",""""id"""":""""123"""",""""source"""":""""test"""",""""specversion"""":""""1.0"""",""""time"""":""""2024-01-01T00:00:00Z"""",""""data"""":""""{\\""""messageDescription\\"""":\\""""Test message\\""""}""""}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was trying for an hour or so to figure out how to make this command better to create the messagebody but was having issues with the serialization. creating the string manually was the easiest way for now. will have to come back to this

Comment on lines -21 to -22
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="6.0.*" />
<PackageReference Include="Microsoft.Extensions.Hosting" Version="6.0.*" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use version 8 of these packages

Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but throwing out the idea that instead of walking users through how to setup the Lambda test tool we could create an Aspire AppHost project and use our Aspire integration for helping users get started. Especially after merge in the work to Aspire for SQS event source support.

@GarrettBeatty
Copy link
Contributor Author

Approved but throwing out the idea that instead of walking users through how to setup the Lambda test tool we could create an Aspire AppHost project and use our Aspire integration for helping users get started. Especially after merge in the work to Aspire for SQS event source support.

i will make a backlog item for this. i like the idea too

@GarrettBeatty GarrettBeatty merged commit b3b009f into dev Mar 24, 2025
7 checks passed
@GarrettBeatty GarrettBeatty deleted the gcbeatty/sampleapps branch March 24, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Release Not Needed Add this label if a PR does not need to be released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants